Skip to content

[ATK] Installing .pc files#14972

Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom
faserg1:master
Dec 7, 2020
Merged

[ATK] Installing .pc files#14972
BillyONeal merged 5 commits intomicrosoft:masterfrom
faserg1:master

Conversation

@faserg1
Copy link
Copy Markdown
Contributor

@faserg1 faserg1 commented Dec 6, 2020

Prepare and install atk.pc file.
This pull request is a part of #9564 solution.

@ghost
Copy link
Copy Markdown

ghost commented Dec 6, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 7, 2020
JackBoosY
JackBoosY suggested changes Dec 7, 2020
View reviewed changes
@JackBoosY JackBoosY changed the title Installing .pc files for ATK port [ATK] Installing .pc files Dec 7, 2020
JackBoosY
JackBoosY suggested changes Dec 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.

@faserg1
Copy link
Copy Markdown
Contributor Author

faserg1 commented Dec 7, 2020

ATK compiles. Now failed GTK for some reason. Very strange.

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Dec 7, 2020 

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
ATK_LIBRARY
    linked by target "gtk-3" in directory D:/buildtrees/gtk/src/gtk+-3-b723a7b846.clean
    linked by target "gdk-3" in directory D:/buildtrees/gtk/src/gtk+-3-b723a7b846.clean
    linked by target "gailutil-3" in directory D:/buildtrees/gtk/src/gtk+-3-b723a7b846.clean

CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_LIBDIR


CMake Generate step failed.  Build files cannot be regenerated correctly.

It seems that because you fixed ATK's pkgconfig, gtk uses the pkgconfig internally to find atk, resulting this error.

@faserg1
Copy link
Copy Markdown
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY Should I bump port-version for gtk if I update CMakeLists.txt in GTK port folder? There was used old 1.0 version

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Dec 7, 2020

@faserg1 No, since this is an error using atk's pkgconfig, I think you should fix pkgconfig.

@faserg1
Copy link
Copy Markdown
Contributor Author

faserg1 commented Dec 7, 2020 •
edited
Loading

@JackBoosY I just do not understand, why in CMakeLists.txt and portfile version is 1.0:

vcpkg/ports/atk/CMakeLists.txt

Line 4 in c303dd0

set(ATK_LIB_SUFFIX 1.0)

if used sources of >2

vcpkg/ports/atk/portfile.cmake

Line 3 in c303dd0

set(ATK_VERSION 2.24.0)

Again, I can modify this line:

vcpkg/ports/gtk/CMakeLists.txt

Line 9 in c303dd0

set(ATK_LIB_SUFFIX 1.0)

to ver2
Or return everything back, like there is ATK ver1

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Dec 7, 2020

Seems that never changes since atk was added to vcpkg, see log.

@faserg1
Copy link
Copy Markdown
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY So leave it as is? Ver1, right?

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Dec 7, 2020

@faserg1 I think your changes is right.

@faserg1
Copy link
Copy Markdown
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY So if update to ver2 I need to patch gtk CMakeFiles.txt

vcpkg/ports/gtk/CMakeLists.txt

Line 9 in c303dd0

set(ATK_LIB_SUFFIX 1.0)

That what I am talking about =)

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Dec 7, 2020

@faserg1 Yep, you're right, I think that's the reason why this regression happened!

@faserg1
Copy link
Copy Markdown
Contributor Author

faserg1 commented Dec 7, 2020

@JackBoosY Ah, no, there is API version of atk, it's ver1. So I need just return back. It's so confusing...
If just look at atk source (atk.pc.in), there will be ver1.

Cflags: -I${includedir}/atk-1.0

@faserg1 faserg1 requested a review from JackBoosY December 7, 2020 09:46
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Dec 7, 2020
@BillyONeal BillyONeal merged commit 08b3a43 into microsoft:master Dec 7, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 7, 2020

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@faserg1 @JackBoosY @BillyONeal